Noisy FIXME

Rob Shearman robertshearman at gmail.com
Wed Oct 1 05:18:45 CDT 2008


2008/9/28 Dimi Paun <dimi at lattica.com>:
> Silence noisy FIXME about uninteresting ExtTextOut() flags.
> Keep the FIXME in the string to make it easily grep-able.
>
> diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c
> index 1e8cac3..c3e4840 100644
> --- a/dlls/gdi32/font.c
> +++ b/dlls/gdi32/font.c
> @@ -1657,7 +1657,7 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, INT y, UINT flags,
>     breakRem = dc->breakRem;
>
>     if (flags & (ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY))
> -        FIXME("flags ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY unimplemented\n");
> +        TRACE("FIXME: flags ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY unimplemented\n");

I think the FIXME should at least by fired once since some of the
flags may cause hard-to-debug display issues.

-- 
Rob Shearman



More information about the wine-devel mailing list