[PATCH 1/2] wininet: Return error codes explicitly from URLCache functions instead of returning a BOOL and storing the error code in the last error value.
Juan Lang
juan.lang at gmail.com
Thu Oct 2 09:51:21 CDT 2008
Hi Rob,
+ * Locks the index for system-wide exclusive access.
+ *
+ * RETURNS
+ * TRUE if successful
+ * FALSE if failed and calls SetLastError.
*/
static LPURLCACHE_HEADER
URLCacheContainer_LockIndex(URLCACHECONTAINER * pContainer)
The comment's off here.
@@ -1346,34 +1353,32 @@ static BOOL
URLCache_AddEntryToHash(LPURLCACHE_HEADER pHeader, LPCSTR lpszUrl, D
* FALSE if the hash table could not be created
*
*/
-static HASH_CACHEFILE_ENTRY
*URLCache_CreateHashTable(LPURLCACHE_HEADER pHeader,
HASH_CACHEFILE_ENTRY *pPrevHash)
+static DWORD URLCache_CreateHashTable(LPURLCACHE_HEADER pHeader,
HASH_CACHEFILE_ENTRY *pPrevHash, HASH_CACHEFILE_ENTRY **ppHash)
I think you forgot to update the comment here.
--Juan
More information about the wine-devel
mailing list