gdi32: if a font substitution is given then only match to that substitution not to the original family name.

Dmitry Timoshkov dmitry at codeweavers.com
Thu Oct 2 09:58:11 CDT 2008


Aric Stewart <aric at codeweavers.com> wrote:

>          LIST_FOR_EACH(family_elem_ptr, &font_list) {
>              family = LIST_ENTRY(family_elem_ptr, Family, entry);
> -            if (!strcmpiW(family->FamilyName, FaceName) ||
> -                (psub && !strcmpiW(family->FamilyName, psub->to.name)))
> +            if ((!psub && !strcmpiW(family->FamilyName, FaceName)) ||
> +                ( psub && !strcmpiW(family->FamilyName, psub->to.name)))
>              {
>                  LIST_FOR_EACH(face_elem_ptr, &family->faces) { 
>                      face = LIST_ENTRY(face_elem_ptr, Face, entry);

Changing the order of 2 comparisons in the 'if' block would be
clear IMO, and would help avoiding to check psub twice.

-- 
Dmitry.



More information about the wine-devel mailing list