Wine: Possible typo in dll/msxml3/tests/domdoc.c
Michael Karcher
wine at mkarcher.dialup.fu-berlin.de
Sat Oct 4 13:44:28 CDT 2008
Hello Huw Davies,
it looks like test_removeChild (introduced by you in commit 187ab1c0)
contains a typo. The test passes both ways, but from the code flow I
suspect that node_list2 was obtained for a reason, namely using it.
Regards,
Michael Karcher
This patch fixes the type, if it turn out to really be a typo.
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 29bebb9..0494e9f 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -1785,7 +1785,7 @@ static void test_removeChild(void)
r = IXMLDOMNode_get_childNodes( node, &node_list2 );
ok( r == S_OK, "ret %08x\n", r);
- r = IXMLDOMNodeList_get_item( node_list, 0, &node4 );
+ r = IXMLDOMNodeList_get_item( node_list2, 0, &node4 );
ok( r == S_OK, "ret %08x\n", r);
r = IXMLDOMElement_removeChild( element, NULL, &node2 );
More information about the wine-devel
mailing list