[PATCH 08/17] mshtml: Added IHTMLStyle::[get|put]_borderimplementation.

Tue Oct 7 04:35:41 CDT 2008

Hi Alistair,

Alistair Leslie-Hughes wrote:
> Hi Jacek,
>  
> >static HRESULT WINAPI HTMLStyle_put_border(IHTMLStyle *iface, BSTR v)
> > {
> >     HTMLStyle *This = HTMLSTYLE_THIS(iface);
> >-    FIXME("(%p)->(%s)\n", This, debugstr_w(v));
> >-    return E_NOTIMPL;
> >+
> >+    TRACE("(%p)->(%s)\n", This, debugstr_w(v));
> >+
> >+    return set_style_attr(This, STYLEID_BORDER, v, 0);
> > }
>  
> My sample code
> style->put_border(L"groove 5");
>  
> produced
> <BODY style="BORDER-RIGHT: 5px groove; BORDER-TOP: 5px groove;
>            BORDER-LEFT: 5px groove; BORDER-BOTTOM: 5px groove" /BODY>
>  
> Will gecko expand "border" to the above?

No, Gecko expands it differently, but CSS handling differs between IE 
versions as well. Although we could fix this difference, there is a lot 
more cases like that so I'd prefer to fix them when we'll find a real 
reason to do so. Otherwise we'd mess MSHTML code for no good reason.

Jacek