[PATCH 1/3] wininet: Validate parameters passed to RetrieveUrlCacheEntryInfoA/W.

Rob Shearman robertshearman at gmail.com
Wed Oct 8 10:30:02 CDT 2008


Hi Paul,

2008/10/8 Paul Vriens <paul.vriens.wine at gmail.com>:
> Rob Shearman wrote:
>>
>> Add tests for this.
>> ---
>>  dlls/wininet/tests/urlcache.c |   25 +++++++++++++++++++++++++
>>  dlls/wininet/urlcache.c       |   14 ++++++++++++++
>>  2 files changed, 39 insertions(+), 0 deletions(-)
>>
>>
>
> Is the following test needed for an app?
>
> +    ret = RetrieveUrlCacheEntryFile(TEST_URL, NULL, NULL, 0);
>
> This crashes on Win9x and NT4. Can we if(0) this test or should we work
> around the issue?

No, it isn't. The test can be if(0)'d or removed.

-- 
Rob Shearman



More information about the wine-devel mailing list