[try2] advapi32: Implement CredReadDomainCredentials stub and tests

Andrey Turkin andrey.turkin at gmail.com
Fri Oct 10 14:51:13 CDT 2008


James Hawkins wrote:
> On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <andrey.turkin at gmail.com> wrote:
>   
>> I can't see any value in commented out test or sort-of-meaningless code
>> comment.
>>
>>     
>
> The tests serve as documentation of the API.  In many cases, that
> documentation is far superior to even msdn.  Just because you know
> that the implementation matches native doesn't mean that someone else
> looking to work on the function knows that.  He'll then waste time
> figuring out what you already know.  Ask yourself the opposite: what's
> the harm in adding such documentation?
>   
Non-misleading comment obviously cannot make any harm, and I can imagine
one (unlikely but not impossible)
case when comment can be helpful so yes, I'll add both commented out
tests and sort-of-meaningless comment :)
Hopefully nobody will object them.

Regards,
  Andrey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-devel/attachments/20081010/d5369728/attachment.htm 


More information about the wine-devel mailing list