[6/6] comdlg32: Add a basic test for IShellView2_CreateViewWindow2.
Reece Dunn
msclrhd at googlemail.com
Tue Oct 14 02:36:46 CDT 2008
2008/10/14 Henri Verbeet <hverbeet at codeweavers.com>:
> + IShellView2_DestroyViewWindow(shell_view2);
> + ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr);
You are missing a "hr = " here, otherwise the ok check is not checking
the return value from DestroyViewWindow.
> + IShellView2_GetCurrentInfo(shell_view2, &folder_settings);
> + ok(folder_settings.ViewMode == FVM_LIST, "view mode is %d, expected %d\n", folder_settings.ViewMode, FVM_LIST);
Shouldn't this also be checking the HRESULT return value from
GetCurrentInfo as per the other calls?
General observation: other tests in Wine explicitly check for specific
hr values, is there a reason you have used the generic SUCCEEDED here
instead of that approach?
- Reece
More information about the wine-devel
mailing list