ole32: quiet a ridiculously noisy fixme (resend)

Huw Davies huw at codeweavers.com
Thu Oct 23 06:35:13 CDT 2008


On Wed, Oct 22, 2008 at 08:34:49PM -0500, Austin English wrote:
> Reduces Open Office 3 application's output from infinity to 7 lines.
> Last patch had an unnecessary whitespace change.
> 
> -- 
> -Austin

> From 0dead16d2588bce8330ed862f8e5b6d3c6bb71a7 Mon Sep 17 00:00:00 2001
> From: Austin English <austinenglish at gmail.com>
> Date: Wed, 22 Oct 2008 20:28:37 -0500
> Subject: [PATCH] ole32: quiet a ridiculously noisy fixme
> 
> ---
>  dlls/ole32/usrmarshal.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c
> index b8487c3..6886dfb 100644
> --- a/dlls/ole32/usrmarshal.c
> +++ b/dlls/ole32/usrmarshal.c
> @@ -2398,7 +2398,11 @@ HRESULT CALLBACK IEnumFORMATETC_Next_Proxy(
>      FORMATETC *rgelt,
>      ULONG *pceltFetched)
>  {
> -    FIXME(":stub\n");
> +    static int quietfixme = 0;
> +    if (quietfixme == 0) {
> +        FIXME(":stub\n");
> +        quietfixme = 1;
> +    }
>      return E_NOTIMPL;
>  }
>  

The real implementation of this would actually result in fewer lines
of code!

See IEnumVARIANT_Next_Proxy / Stub (in oleaut32/usrmarshal.c) for an
example.

Huw.
-- 
Huw Davies
huw at codeweavers.com



More information about the wine-devel mailing list