[PATCH] msvcmaker: added COM_NO_WINDOWS_H to support midl-generated headers for __WINESRC__ components.

Rob Shearman robertshearman at gmail.com
Thu Oct 23 12:08:21 CDT 2008


2008/10/23 Alexandre Julliard <julliard at winehq.org>:
> "Rob Shearman" <robertshearman at gmail.com> writes:
>
>> 2008/10/18 Reece Dunn <msclrhd at googlemail.com>:
>>> The midl generated code allows you to define COM_NO_WINDOWS_H to
>>> prevent the inclusion of windows.h. That define is thus added to those
>>> provided by msvcmaker.
>>
>> Any reason why this hasn't been applied yet?
>>
>> I've been testing with this applied and I believe it is an improvement
>> and gets more DLLs compiling.
>
> I don't think it's the right approach. If midl-generated code uses
> windows.h then widl-generated code should too, and we should ensure that
> it works in both cases, for instance by disabling the check when it's
> included from generated files or something along those lines.

Yes, I agree and I have plans to make widl do so. However, I don't see
how we can detect if we are being included from widl- or
midl-generated header files. My plan was to simply define
COM_NO_WINDOWS_H for all __WINESRC__ files.

-- 
Rob Shearman



More information about the wine-devel mailing list