msi: Uninitialized variable fix (Coverity)

Andrew Talbot Andrew.Talbot at talbotville.com
Tue Sep 9 16:24:47 CDT 2008


James Hawkins wrote:

> On Tue, Sep 9, 2008 at 3:54 PM, Andrew Talbot
> <andrew.talbot at talbotville.com> wrote:
>> Fix for Coverity error CID: 762.
>>
>> [...]
>> -    RegCloseKey(userdata);
>> +    if (userdata) RegCloseKey(userdata);
>>     return rc;
> 
> Please don't add another NULL-before-free check.
> 

Hi James,

Sorry, I don't understand what I have done wrong. RegCloseKey() will return ERROR_INVALID_HANDLE if called with hkey==NULL.

-- 
Andy.




More information about the wine-devel mailing list