devenum: Fix order of operations bug (Coverity id 709)

Chris Robinson chris.kcat at gmail.com
Wed Sep 10 15:34:22 CDT 2008


On Wednesday 10 September 2008 11:34:03 am Juan Lang wrote:
> dwMediaTypeSize + (dwMediaTypeSize < 2 ? 1 : dwMediaTypeSize / 2)

I'm pretty sure this would come out as:
dwMediaTypeSize + (dwMediaTypeSize < (2 ? 1 : dwMediaTypeSize) / 2)

But even if it doesn't, I don't think it'd hurt to be more explicit:
dwMediaTypeSize + ((dwMediaTypeSize < 2) ? 1 : (dwMediaTypeSize/2))



More information about the wine-devel mailing list