[1/4] msi/tests: Fix test when content indexing is disabled.

Nicolas Le Cam niko.lecam at gmail.com
Fri Apr 10 05:53:16 CDT 2009


2009/4/10 Alexandre Julliard <julliard at winehq.org>:
> Nicolas Le Cam <niko.lecam at gmail.com> writes:
>
>> @@ -2308,7 +2308,7 @@ static void test_setpropertyfolder(void)
>>
>>      r = MsiInstallProductA(msifile, NULL);
>>      ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r);
>> -    if (GetFileAttributesA(path) == FILE_ATTRIBUTE_DIRECTORY)
>> +    if (GetFileAttributesA(path) & FILE_ATTRIBUTE_DIRECTORY)
>>      {
>>          ok(delete_pf("msitest\\added\\maximus", TRUE), "File not installed\n");
>>          ok(delete_pf("msitest\\added", FALSE), "File not installed\n");
>
> You most likely need to check for GetFileAttributesA failure first.
>
> --
> Alexandre Julliard
> julliard at winehq.org
>
Thanks, didn't thought about that.
I will resubmit.

-- 
Nicolas Le Cam



More information about the wine-devel mailing list