try3 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
Paul Vriens
paul.vriens.wine at gmail.com
Tue Apr 14 07:15:53 CDT 2009
Guy Albertelli wrote:
> Enhance QueryDosDevice test for attempting to return all devices.
> Add tests for GetVolumeInformationA testing the different root dir formats.
> ---
> dlls/kernel32/tests/volume.c | 132 +++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 129 insertions(+), 3 deletions(-)
>
>
>
> ------------------------------------------------------------------------
>
>
You're leaking memory here (although it's just a test we try to have
these as clean as possible):
+ buffer = HeapAlloc( GetProcessHeap(), 0, buflen );
+ ret = QueryDosDeviceA( NULL, buffer, buflen );
+ ok(ret && GetLastError() != ERROR_INSUFFICIENT_BUFFER,
+ "QueryDosDevice buffer to small\n");
+ if (GetLastError() == ERROR_INSUFFICIENT_BUFFER) return;
Could you also change the skip()'s into win_skip()'s:
+ if (!pGetVolumeInformationA) {
+ skip("GetVolumeInformationA not found\n");
+ return;
+ }
+ if (!pGetVolumeNameForVolumeMountPointA) {
+ skip("GetVolumeNameForVolumeMountPointA not found\n");
+ return;
+ }
That way they will only be skipped on Windows if the functions are not
present. If the functions are not present on Wine (for whatever reason)
a win_skip will show a failure on wine.
--
Cheers,
Paul.
More information about the wine-devel
mailing list