[1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA

Juan Lang juan.lang at gmail.com
Mon Apr 27 15:14:23 CDT 2009


Hi Jeff, I just wanted to clarify one of Detlef's comments:

>> -    ok( len == sizeof( expect4 ), "Got size %d\n", len);
>> +    ok( len == sizeof( expect4 ), "Expected size to be %d, got %d\n",
>> sizeof( expect4 ), len);
>
> Do not use sizeof() in a test.

Using sizeof is okay, but printing the result of it is not, due to
compile warnings this will introduce on some platforms.  Basically,
omit this change from your patch.

Thanks,
--Juan



More information about the wine-devel mailing list