Office 2007 MSI Crash - Null dereference @ MsiViewExecute

James Hawkins truiken at gmail.com
Thu Apr 30 12:08:25 CDT 2009


On Thu, Apr 30, 2009 at 4:03 AM, Austin English <austinenglish at gmail.com> wrote:
> On Tue, Apr 28, 2009 at 9:27 PM, Mike Kaplinskiy
> <mike.kaplinskiy at gmail.com> wrote:
>> I was looking at the trace of the crash from bug 17600, and it looks like
>> a custom action is calling MsiViewExecute with a null hRec.
>>
>> I (sadly) don't know much about the wine MSI architecture, but the
>> msiobj_lock on line 484 should fail since rec will never be fetched
>> (null). I think the intention was to make it query->hdr (as it is
>> released later).
>
> A testcase for it would show if you're right or wrong ;-).
>

Not really.  If you grep through the msi tests, you'll see that we
call MsiViewExecute with NULL hRec all over the place.  That doesn't
mean there isn't a bug, just saying.

-- 
James Hawkins



More information about the wine-devel mailing list