shlwapi: Correct AssocCreate Tests

Michael Stefaniuc mstefani at redhat.com
Wed Aug 5 03:44:16 CDT 2009


Hello Alistair,

Alistair Leslie-Hughes wrote:
> diff --git a/dlls/shlwapi/tests/assoc.c b/dlls/shlwapi/tests/assoc.c
> index fd2b868..9a52edb 100644
> --- a/dlls/shlwapi/tests/assoc.c
> +++ b/dlls/shlwapi/tests/assoc.c
> @@ -252,11 +252,13 @@ static void test_assoc_create(void)
>      ok(hr == E_INVALIDARG, "Unexpected result : %08x\n", hr);
> 
>      hr = pAssocCreate(CLSID_QueryAssociations, &IID_NULL, (LPVOID*)&pqa);
> -    ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL /* win98 */
> +    ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL || /* win98 */
> +       hr == E_NOINTERFACE
>          , "Unexpected result : %08x\n", hr);
this looks ugly; the 2 lines can be joined into one without exceeding
80 chars in width.

> 
>      hr = pAssocCreate(IID_NULL, &IID_IQueryAssociations, (LPVOID*)&pqa);
> -    ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL /* win98 */
> +    ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL || /* win98 */
> +       hr == E_INVALIDARG
>          , "Unexpected result : %08x\n", hr);
Same here.

>      hr = pAssocCreate(CLSID_QueryAssociations, &IID_IQueryAssociations, (LPVOID*)&pqa);

bye
	michael



More information about the wine-devel mailing list