Weekly cppcheck run against Aug 27 Git Tree
Dmitry Timoshkov
dmitry at codeweavers.com
Fri Aug 28 02:40:38 CDT 2009
"James McKenzie" <jjmckenzie51 at earthlink.net> wrote:
>> False positive, apparently the numbers are hardcoded as:
>> 72 char msg[128];
>> 88 msg[10 + 3 * 16] = ' '; // = 58<127
>>
> Why not just say 58 instead of the complex math?
>> 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127
>>
>>
> Same here. Why not 75 instead of the math formula?
Because that's done that way to make it easier to understand
the logic for the programmer. If a tool can't cope with it -
that tool is broken.
--
Dmitry.
More information about the wine-devel
mailing list