[PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W

Maarten Lankhorst m.b.lankhorst at gmail.com
Wed Dec 9 08:57:08 CST 2009


Hi AJ,

Alexandre Julliard schreef:
> Maarten Lankhorst <m.b.lankhorst at gmail.com> writes:
>   
>> +    data.DataFlow = ppd->DataFlow;
>> +    len = strlen(ppd->DeviceName)+1;
>> +    data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len);
>> +    if (!data.DeviceName)
>> +        return E_OUTOFMEMORY;
>> +    MultiByteToWideChar(CP_ACP, 0, ppd->DeviceName, -1, data.DeviceName, len );
>>     
>
> The W length handling is broken.
>   
Yep, I wonder why valgrind didn't catch it.. sent updated version

Cheers,
Maarten



More information about the wine-devel mailing list