(resend)shlwapi: implement SHPropertyBag_ReadLONG

Aric Stewart aric at codeweavers.com
Mon Dec 14 07:22:38 CST 2009


You are probibly right.  What is an example of a variant type that 
cannot be converted to I4 so that I can write a test?

thanks!
-aric

Jacek Caban wrote:
> Hi Aric,
> 
> On 12/11/09 10:44 PM, Aric Stewart wrote:
>> ---
>>  dlls/shlwapi/ordinal.c    |   25 +++++++++++++++++++++++++
>>  dlls/shlwapi/shlwapi.spec |    2 +-
>>  2 files changed, 26 insertions(+), 1 deletions(-)
> 
> +    hr = IPropertyBag_Read(ppb, pszPropName,&var, NULL);
> +    if (SUCCEEDED(hr))
> +        *pValue = V_I4(&var);
> 
> 
> You should make sure that var is of VT_I4 type and return an error or do 
> conversion if it's not.
> 
> Thanks,
>     Jacek
> 



More information about the wine-devel mailing list