[PATCH 14/14] [WineDbg]: fix some casts issues on 64bit platform

Eric Pouech eric.pouech at orange.fr
Mon Dec 14 14:51:21 CST 2009


Alexandre Julliard a écrit :
> Eric Pouech <eric.pouech at orange.fr> writes:
>
>   
>> diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y
>> index 855407f..7ed6307 100644
>> --- a/programs/winedbg/dbg.y
>> +++ b/programs/winedbg/dbg.y
>> @@ -281,9 +281,9 @@ info_command:
>>      | tINFO tCLASS              { info_win32_class(NULL, NULL); }
>>      | tINFO tCLASS tSTRING     	{ info_win32_class(NULL, $3); }
>>      | tINFO tWND                { info_win32_window(NULL, FALSE); }
>> -    | tINFO tWND expr_rvalue    { info_win32_window((HWND)$3, FALSE); }
>> +    | tINFO tWND expr_rvalue    { info_win32_window((HWND)(DWORD_PTR)$3, FALSE); }
>>      | tINFO '*' tWND            { info_win32_window(NULL, TRUE); }
>> -    | tINFO '*' tWND expr_rvalue { info_win32_window((HWND)$4, TRUE); }
>> +    | tINFO '*' tWND expr_rvalue { info_win32_window((HWND)(DWORD_PTR)$4, TRUE); }
>>      | tINFO tPROCESS            { info_win32_processes(); }
>>      | tINFO tTHREAD             { info_win32_threads(); }
>>      | tINFO tEXCEPTION          { info_win32_exceptions(dbg_curr_tid); }
>>     
>
> It seems to me that it's expr_rvalue itself that should be a DWORD_PTR,
> it can be used to specify addresses at other places too.
>
>   
actually, you've done just that in a one of your previous patches ;-)
this is cruft left over from the merge <g>

A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)






More information about the wine-devel mailing list