[PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

Juan Lang juan.lang at gmail.com
Wed Dec 16 13:09:15 CST 2009


Hi Amine,

this patch has no functional benefit.  For example,
-    HRESULT hr;

     TRACE("\n");

-    hr = SMTPTransport_ParseResponse(This, pBuffer, &response);
-    if (FAILED(hr))
+    if (FAILED(SMTPTransport_ParseResponse(This, pBuffer, &response)))

This has the dubious benefit of removing a local variable that was
used before.  I can't fathom why this is a good thing.
--Juan



More information about the wine-devel mailing list