[PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.

Amine Khaldi amine48rz at gmail.com
Wed Dec 16 13:12:21 CST 2009


>
> Hi Amine,
>    
Hi Juan,

> this patch has no functional benefit.  For example,
> -    HRESULT hr;
>
>       TRACE("\n");
>
> -    hr = SMTPTransport_ParseResponse(This, pBuffer,&response);
> -    if (FAILED(hr))
> +    if (FAILED(SMTPTransport_ParseResponse(This, pBuffer,&response)))
>
> This has the dubious benefit of removing a local variable that was
> used before.  I can't fathom why this is a good thing.
>    

It makes the code use one less variable. I don't see how is this 
dubious, but I understand that it's trivial.

WBR,
Amine.



More information about the wine-devel mailing list