[PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests

Nikolay Sivov bunglehead at gmail.com
Mon Dec 21 08:53:36 CST 2009


On 12/21/2009 17:49, Paul Vriens wrote:
> On 12/21/2009 03:37 PM, Nikolay Sivov wrote:
>> On 12/21/2009 17:21, Paul Vriens wrote:
>>> On 12/21/2009 02:32 AM, Nikolay Sivov wrote:
>>>> Fix last error in SearchPathA/W with tests
>>>>
>>> Hi Nikolay,
>>>
>>> Any reason all tests are relying on both the A- and W-version being
>>> available?
>>>
>> MSDN lied again, it's documented to be available in win2k.
>
> Well, I've noticed that most of the pages contain win2k as the minimum 
> probably because they don't support NT4/Win9x anymore?
Maybe, but sometimes earlier version mentioned too. Doesn't matter actually.
>
>> I see, probably it's better to determine win9x indirectly here, to avoid
>> not obvious checks, I'll take a look for tomorrow
>> patch set, playing with testbot.
>
> A check for last error being ERROR_CALL_NOT_IMPLEMENTED after 
> GetWindowsDirectoryW would suffice I guess.
>
Maybe, if you have some time for it please do it, I can't be ready for 
today commits. The only things matters here is to keep all tests from 
this patch, cause Wine's implementation differs for W/A in parameter checks.




More information about the wine-devel mailing list