[PATCH 2/3] wininet: Always set lpszUrlPath in InternetCrackUrlW.

[Alexandre Julliard]

Jacek Caban <jacek at codeweavers.com> writes:

> ---
>  dlls/wininet/internet.c |   38 +++++++++++++-------------------------
>  1 files changed, 13 insertions(+), 25 deletions(-)

It doesn't work here:

../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok
wine: Unhandled page fault on read access to 0x00000000 at address 0x68699521 (thread 0009), starting debugger...
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x68699521).
Register dump:
 CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
 EIP:68699521 ESP:0032d180 EBP:0032d1f8 EFLAGS:00010297(  R- --  I S -A-P-C)
 EAX:cbcd24a4 EBX:686b1894 ECX:3432db62 EDX:6865b6c4
 ESI:00000000 EDI:00000000
Stack dump:
0x0032d180:  00000000 00000000 00000000 00000000
0x0032d190:  00000000 00000000 00000000 00000000
0x0032d1a0:  00000000 00000000 00000000 0000000c
0x0032d1b0:  00000000 00000000 6865b6b8 00000000
0x0032d1c0:  00000006 00000000 00000000 00000000
0x0032d1d0:  00000000 00000000 00000000 00000000
Backtrace:
=>0 0x68699521 InternetCrackUrlW+0x3c1(lpszUrl_orig=0x6865b6b8, dwUrlLength_orig=6, dwFlags=0, lpUC=0x32fb44) [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet (0x0032d1f8)
  1 0x6869cd2c INTERNET_InternetOpenUrlW+0xec(hIC=0x148d18, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2846] in wininet (0x0032fb98)
  2 0x6869d34e InternetOpenUrlW+0x10e(hInternet=0x1, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2990] in wininet (0x0032fbf8)
  3 0x6864d4f3 test_null+0x3f3() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:400] in wininet_test (0x0032fca8)
  4 0x6864f71b func_internet+0xbab() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:850] in wininet_test (0x0032fd98)
  5 0x686560c0 run_test+0x130(name="internet.c") [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:537] in wininet_test (0x0032fdd8)
  6 0x686562ae main+0x11e(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:586] in wininet_test (0x0032fe88)
  7 0x68656d34 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in wininet_test (0x0032feb8)
  8 0x7b8769d5 start_process+0x55(peb=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1038] in kernel32 (0x0032fee8)
  9 0x7bc6f9e4 call_thread_func+0xc() in ntdll (0x0032fef8)
  10 0x7bc6fbc0 call_thread_entry_point+0x70(entry=0x7b876980, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2391] in ntdll (0x0032ffc8)
  11 0x7bc4cd5a in ntdll (+0x3cd5a) (0x0032ffe8)
0x68699521 InternetCrackUrlW+0x3c1 [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet: cmpw	$10,0x0(%edi)
311	    for (end = ptr + n; ptr < end; ptr++) if (*ptr == ch) return (WCHAR *)(ULONG_PTR)ptr;

-- 
Alexandre Julliard
julliard at winehq.org