shdocvw: Correct OnAmbientPropertyChange regession

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Tue Feb 3 18:54:15 CST 2009


"Jacek Caban" <jacek at codeweavers.com> wrote in message 
news:4988D589.9080708 at codeweavers.com...
> Alistair Leslie-Hughes wrote:
>> Hi,
>>    After testing on XP, it appears that OnAmbientPropertyChange when
>> passwed DISP_UNKNOWN doesnt check all properties.
>>
>> Changelog:
>>     shdocvw: Correct OnAmbientPropertyChange regession
>
> +    CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED);
> +    CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT);
> +    CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE);
> +    CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL);
> +    CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT);
> +    CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE);
>
>
>
> These checks don't make sense here. If you don't set these calls as
> expected, CHECK_EXPECT will fail when they are called.
>
Hi Jacek.

I was unsure about the SET_EXPECT.  Thanks

Best Regards
 Alistair Leslie-Hughes






More information about the wine-devel mailing list