ioports.c change -> buffer overflow ... bug?

Florian Tobias Schandinat FlorianSchandinat at gmx.de
Mon Feb 9 03:29:33 CST 2009


Marcus Meissner schrieb:
> Hi Florian,
> 
> You are calling get_timer_val(3) in ioports.c 
> (if (chan == 3) ... going down to get_timer_val(chan))
> 
> Howver, tmr_8253 is just a 3 element array, so [3] will run over the end,
> 
> Is your code right? The change comes from this commit:
> 
> 	commit edbd4885542e4545439906df950a68dc48e70839
> 	Author: Florian Tobias Schandinat <FlorianSchandinat at gmx.de>
> 	Date:   Tue Feb 3 18:26:04 2009 +0100
> 
> 	    winedos: Improve PIT emulation.
> 
> Ciao, Marcus

Sorry, I forgot to adjust the calls in readback case where the channel 
information is stored in different bits. Thanks for reporting, the 
attached patch should fix it.


Greetings,

Florian Tobias Schandinat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wine-pit-fix.patch
Type: text/x-diff
Size: 0 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20090209/fa4a4018/attachment.patch 


More information about the wine-devel mailing list