mshtml/tests: Better check for installed Gecko.

Alexandre Julliard julliard at winehq.org
Tue Feb 10 06:24:36 CST 2009


Jacek Caban <jacek at codeweavers.com> writes:

> @@ -4199,9 +4199,8 @@ static void run_domtest(const char *str, domtest_t test)
>      }
>  
>      hres = IHTMLDocument2_get_body(doc, &body);
> -    ok(hres == S_OK, "get_body failed: %08x\n", hres);
> -
> -    if(body) {
> +    if(hres != E_UNEXPECTED) {
> +        ok(hres == S_OK, "get_body failed: %08x\n", hres);
>          IHTMLElement_Release(body);

We've been through this before, there needs to be at least one failure
if mshtml is non-functional because Gecko is missing. I'd suggest to
remove the Gecko install workaround and have the test force the install
in all cases, it's not useful to run the tests without Gecko anyway.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list