Need help on couple of patches

Jérôme Gardou jerome.gardou at gmail.com
Wed Feb 18 12:31:02 CST 2009


Igor Tarasov a écrit :
> Hello!
>
> I've written 2 patches, and I need advice on both of them.
>
> First one is here:
> http://www.winehq.org/pipermail/wine-patches/2009-February/069463.html
>
> It's a single-line patch that adds forwarding notification that was
> omitted in wine code. This fix looks pretty simple, but it included
> lots of reading/testing/debugging, and here is what I came with. And
> as I told there it fixes one wine bugzilla bug.
>
> But as I see, it was not comitted, so I am asking for advice: what
> could I do in order to make it go through?
>
> Another patch is here: http://bugs.winehq.org/show_bug.cgi?id=12701
>
> The patch adresses 3 problems that all together fix that bug. My
> question there was if I should send it in one patch or in several. But
> it seems that no one have noticed that post.
>
> Any help and advice is appreciated. Thanks.
>
>
>
>   
I can't answer your first question, but for the second one : wine 
developers policy is "one patch per fix". So you should send three patches.



More information about the wine-devel mailing list