[oleaut 3/3] oleaut32: Implement IPropertyBag::Read proxying

Rob Shearman robertshearman at gmail.com
Thu Jan 1 12:58:21 CST 2009


2009/1/1 Michael Karcher <wine at mkarcher.dialup.fu-berlin.de>:
> +  hr = IPropertyBag_RemoteRead_Proxy(This, pszPropName, &outVariant, pErrorLog,
> +                                       V_VT(pVar), pUnk);
> +  if(SUCCEEDED(hr))
> +    hr = VariantCopy(pVar, &outVariant);
> +
> +  return hr;

You're leaking the memory in outVariant here, since VariantCopy does a
deep copy of all of the data. Is there a reason you don't just pass
pVar into IPropertyBag_RemoteRead_Proxy?

-- 
Rob Shearman



More information about the wine-devel mailing list