Patch implementing riched20 : EM_PASTESPECIAL -- critique?

Arren Lex arrenlex at gmail.com
Fri Jan 2 18:01:18 CST 2009


Hello, all;

Attached is a patch that implements the EM_PASTESPECIAL riched20
message, which pastes with a specified clipboard format --
http://msdn.microsoft.com/en-us/library/bb774214(VS.85).aspx

Because there is (apparently) no ANSI clipboard implemented, the
CF_TEXT clipboard format pastes garbage, so I have put in a workaround
which treats a CF_TEXT as a CF_UNICODETEXT call. It prints a fixme
when it does this, and when the ANSI clipboard is implemented the "if"
block can simply be taken out to start using it.

This patch was written to fix bug 14530 --
http://bugs.winehq.org/show_bug.cgi?id=14530

It is made against git commit bf25837eb7c08dc7faf13b886f6aed79a02506b8
(the tagging of 1.1.12) which is the latest at the time of writing.

This is my first ever patch, and I am not familiar with wine or
riched20 at all, so I would love to have some feedback about it before
I submit it to the patches list. Can anyone suggest improvements?

Thank you,
- Alexander Dorokhine
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pastespecial-fix.patch.txt
Url: http://www.winehq.org/pipermail/wine-devel/attachments/20090102/fcd8168a/attachment-0001.txt 


More information about the wine-devel mailing list