dlls/dinput/effect_linuxinput.c: Check return value of 'write'. (bug # 16413)

Austin English austinenglish at gmail.com
Sun Jan 4 20:49:43 CST 2009


On Sun, Jan 4, 2009 at 4:55 PM, Vitaliy Margolen
<wine-devel at kievinfo.com> wrote:
> titon barua wrote:
>> ---
>>      /* we don't care about the success or failure of this call */
>> -    write(*(This->fd), &event, sizeof(event));
>> +    /* print errors if they occur */
>> +    if (write(*(This->fd), &event, sizeof(event)) == -1) perror ( NULL );
> What's the point of your patch? What part of the comment isn't clear to you?
> Also don't use perror. Wine has ERR(), WARN(), TRACE() macros for that.
>
> Vitaliy
>
>
>
>

GCC is complaining about the ignored return value.

-- 
-Austin



More information about the wine-devel mailing list