wined3d: Fix a memory leak in compile_state_table()

Henri Verbeet hverbeet at gmail.com
Tue Jan 6 04:51:54 CST 2009


2009/1/6 Rico Schüller <kgbricola at web.de>:
> Allan Tong schrieb:
>> Wrong pointer was being passed to HeapFree.
>>
>>  - Allan
>>
>>
> Why did you remove these two lines? Was this your intention?
> -                    dev_multistate_funcs[cur[i].state][0] =
> multistate_funcs[cur[i].state][0];
> -                    dev_multistate_funcs[cur[i].state][1] =
> multistate_funcs[cur[i].state][1];
>
Because HeapReAlloc() should already take care of any copying, if
needed. Using HeapReAlloc() without checking the result first isn't
safe of course, but neither was the original code.


More information about the wine-devel mailing list