[4/5] widl: Rewrite of cant_be_null

Alexandre Julliard julliard at winehq.org
Mon Jan 12 08:44:07 CST 2009


Michael Karcher <wine at mkarcher.dialup.fu-berlin.de> writes:

> As Rob Shearman commented to my patch "Null-check pointers with [size_is]",
> the code flow in cant_be_null is non-obvious, the variable type check could
> be included into this function and last but not least it is buggy. This
> is a hopefully cleaner rewrite of this function, which still fixes the
> problem the original patch intended to fix, namely null-checking of pointers
> declared with size_is. This matches midl behaviour.

It still doesn't seem to be doing the right thing on the svcctl client
code. The current code matches widl for all functions except
QueryServiceStatusEx, yours has a lot more differences. I'd also suggest
adding some test cases for this.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list