Dead code in winedbg

Eric Pouech eric.pouech at orange.fr
Wed Jan 14 15:13:54 CST 2009


Francois Gouget a écrit :
> Hi,
>
> I have noticed that expr_alloc_uconstant() is unused in winedbg.
> Is that normal?
>   

the main point is that the lexer only returns signed integers, while it 
should return both signed and unsigned integers
therefore this code was left to handle possibly unsigned:s from 
0x80000000 up to 0xfffffffff (which current code doesn't)
the proper fix would be to fix the lexer to return both signed and 
unsigned integers

for example:
WineDbg> p 0x80000000
-2147483648
while it should be
2147483648

A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)





More information about the wine-devel mailing list