python regression tests - a monster hammer to keep wine "in check" :)

Luke Kenneth Casson Leighton lkcl at lkcl.net
Sat Jan 17 14:42:38 CST 2009


lkcl at gonzalez:~/src/python2.5-2.5.2$ ./python.exe Lib/test/test_file.py -v
testIteration (__main__.OtherFileTests) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.008s

OK

yaay!

so, obviously, the regression tests in python aren't _that_ good, as
they haven't spotted the seek position off-by-one bug.

On Sat, Jan 17, 2009 at 8:40 PM, Luke Kenneth Casson Leighton
<lkcl at lkcl.net> wrote:
> spiffo, dan, jolly good show :)
>
> that fixed both #16982 _and_ #16970 - the character reading bit - with
> the exception that the ftell() position, which was wrong _before_ this
> patch, is still also wrong, as you suspected.
>
> l.
>
> On Sat, Jan 17, 2009 at 7:15 PM, Dan Kegel <dank at kegel.com> wrote:
>> Luke wrote:
>>> [MSVCRT__filbuf() needs to strip CR's.]
>>
>> Here's a quickie patch that kind of gets there,
>> but fails an ftell test.  My in-laws arrive in ten
>> minutes, so I probably can't go any further on
>> it this weekend.
>>
>> There are probably other simplifications that
>> could be made beyond this, I didn't rip out
>> all the scattered places that were involved
>> in \r removal.
>> - Dan
>>
>



More information about the wine-devel mailing list