Ole32: le32toh/le16toh conflict in storage32.h's endian macros

Juan Lang juan.lang at gmail.com
Wed Jan 21 20:41:27 CST 2009


Hi Austin,

> I started to send a patch to #ifdef,#undef, but I'm not sure that's
> right...which definition should we be using here, NetBSD's or Wine's?

It doesn't really matter.  I came up with the names as a shorthand for
the longer Win32 (well, ntdll really) name, and also to be able to
define them as a no-op on little-endian machines.  You can come up
with a name that doesn't conflict and replace those definitions if you
like.  That has the advantage of not breaking it on big-endian machine
on which le32toh et al aren't defined.

> Furthermore, do we need to add le64toh/htole64?

Not unless you see a need.  I didn't see any 64-bit types in the
property storage when I was working on it.
--Juan



More information about the wine-devel mailing list