First complete test run passing on a Windows platform

[Ge van Geldorp]

Florian,

> From: Florian Köberle [mailto:florian at fkoeberle.de] 
> How many cores do your processor have?
> I have a dual core which might make the difference.

I ran inside a VM that had 1 CPU assigned, so single core.

> How exactly do you execute the tests?
> I executed "../../../tools/runtest -q menu" about 20 times 
> without any failure.

I copied user32_crosstest.exe to C:\winetest, then created a small batch
file runtest.cmd:

@echo off
cd \winetest
user32_crosstest menu
pause

Put a shortcut to runtest.cmd on the desktop and then set the shortcut to
run Minimized (during my regular test runs the console is minimized too, so
I thought I'd mimic that as much as possible). Then double click the
shortcut, wait until the test is done, restore the console window and look
at the results. 

> Did my patch reduce the number of failures?
> I am asking as I wonder, if I should send the patch anyway to 
> wine-patches or not.

It's hard to say because it doesn't reproduce consistently. My feeling is
that it doesn't reduce the number of failures, but no hard data to back that
up.

> Does removing the Sleep(500) increase the fail rate?
> I tried to remove it but it had no effect for me at all.

No, I don't see an effect either.

I've done some more experimenting and can get the problem to reproduce more
consistently (like 95% of the time instead of 25%) by launching my shortcut
twice (so I have two test runs going at the same time). Then both of the
runs will usually show problems.

Gé.