comctl32: Fix propsheet size calculation (resent)
Vitaliy Margolen
wine-devel at kievinfo.com
Fri Jan 30 09:45:34 CST 2009
Alexandre Julliard wrote:
> Vitaliy Margolen <wine-devel at kievinfo.com> writes:
>
>> Alexandre Julliard wrote:
>>> Vitaliy <vitaliy at kievinfo.com> writes:
>>>
>>>> + /* Get non-client size */
>>>> + if (!psInfo->isModeless)
>>>> + {
>>>> + RECT rc1;
>>>> +
>>>> + GetWindowRect(hwndDlg, &rc);
>>>> + GetClientRect(hwndDlg, &rc1);
>>>> + tabOffsetX = rc.right - rc.left - (rc1.right - rc.left);
>>>> + tabOffsetY = rc.bottom - rc.top - (rc1.bottom - rc.top);
>>> That doesn't make sense. What are you trying to compute here?
>>>
>> The size of non-client area - window borders and the title.
>
> Even after fixing the typos it doesn't really make sense, especially
> with names like tabOffsetX. You probably want AdjustWindowRect or
> something like that.
>
Oh, indeed. I will resubmit using AdjustWindowRect(). Thanks.
Vitaliy.
More information about the wine-devel
mailing list