[1/3] WineD3D: An indirect address op can adjust min and max at the same time

Henri Verbeet hverbeet at gmail.com
Wed Jul 8 01:46:02 CDT 2009


2009/7/7 Stefan Dösinger <stefan at codeweavers.com>:
>                      if (reg->idx <= ((IWineD3DVertexShaderImpl *)This)->min_rel_offset)
> +                    {
>                          ((IWineD3DVertexShaderImpl *)This)->min_rel_offset = reg->idx;
> -                    else if (reg->idx >= ((IWineD3DVertexShaderImpl *)This)->max_rel_offset)
> +                    }
> +                    if (reg->idx >= ((IWineD3DVertexShaderImpl *)This)->max_rel_offset)
> +                    {
>                          ((IWineD3DVertexShaderImpl *)This)->max_rel_offset = reg->idx;
> +                    }
If you're going to fix it, you might as well fix it properly. There's
no point in assigning min_rel_offset or max_rel_offset if they're
already the same as reg->idx.



More information about the wine-devel mailing list