gdi32: Ensure child fonts have names

Dmitry Timoshkov dmitry at codeweavers.com
Fri Jul 31 10:05:57 CDT 2009


"Aric Stewart" <aric at codeweavers.com> wrote:

> load_child_font calls neither WineEngCreateFontInstance nor GetEnumStructs.
> 
> It allocates the the child font structure above in the function sets the 
> few fields it thinks it needs and then goes on. I see no evidence that 
> it is being expected to have been set at any other point.

Then child->font->name should be initialized explicitly, 'if ()' check
is redundant. Setting it to child->font->font_desc.lf.lfFaceName looks
also incorrect, other places set it to face->family->FamilyName.

-- 
Dmitry.



More information about the wine-devel mailing list