[3/3] wininet: Add missing empty line to end of headers list

Alexandre Julliard julliard at winehq.org
Fri Jun 5 09:54:43 CDT 2009


Jason Green <jave27 at gmail.com> writes:

> Hi Alexandre,
>
> Here's the response from the patch author, Eric van Beurden:
>
> This check was added because the login server for one of our games was
> sending a final line that either contained only whitespace or was received
> as an empty string and that was being discarded.  This left the headers list
> without a terminating empty line (ie: ending in "\r\n\r\n").  The game then
> went to retrieve and examine the CRLF raw headers and would just spin
> endlessly because the terminating empty line was not present.  Adding this
> check allowed the game to succeed on the login immediately.

Adding the termination is fine if an app needs it, my point is that your
if() check is useless, because there will never already be a termination
in the buffer at that point.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list