Request for Patchreview

Juan Lang juan.lang at gmail.com
Mon Jun 15 11:11:24 CDT 2009


Hi André,

> Can someone please review my patch
> http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html.

I have a couple minor comments:

+
+   IDS_INSTALL_FILTER, "Installation
Program\0*Instal*.exe;*Setup*.exe;*.msi\0Programs\0*.com;*.cmd;*.exe\0All
Files (*.*)\0*.*\0\0"

Nit:  the blank line isn't needed.

Nit:  "Installation Program" should be "Installation Programs".

The filter looks strange to me.  At least in Windows, it isn't usual
to see a wildcard in the name part of the filter other than *.
Usually it's something like *.extension.  If you think it's important
to do it this way, at least change it to Install*.exe, rather than
Instal*.exe.  Also, are .com and .cmd installers common in Windows?
Usually I see .exe, and sometimes .msi.

In my opinion, something like the following would be better:
"Installation Programs (*.exe;*.msi)\0*.exe;*.msi\0Programs
(*.exe)\0*.exe\0Microsoft Installer Packages (*.msi)\0*.msi\0All
Files(*.*)\0*.*\0\0"
--Juan



More information about the wine-devel mailing list