[1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop

Tobias Jakobi liquid.acid at gmx.net
Tue Jun 16 03:34:52 CDT 2009


Hi Henri,

I do this for patch 3/4, otherwise the code gets kinda ugly.

A good point probably is that the code is indeed rarely used, since it
was written specifically for the FX generation. So it makes sense to
skip it early -> put it into a seperate loop and "conceal" it with an
if-statement.
Like Stefan stated on the FDO bugtracker: "which can be
disabled fairly effectively at runtime if not needed" (referring to the
np2fixup code)
I want it to stay this way (which includes mostly not interfering with
the rest of the code IF that's possible).


However the main point is patch 3/4, where a seperate loop makes the
code a lot neater - which I think is a good thing to have :)

Greets,
Tobias



More information about the wine-devel mailing list