[Bug 18786] patch
juan.lang at gmail.com
Tue Jun 16 10:51:01 CDT 2009
> Could you look at bug 18786 and my suggested patch to get MINITAB
> working again. It is a partial revert of one of your patches from
> 6/25/08 (see comment #7).
> I have verified that the associated tests (dlls/inetmib1/tests/main.c)
> exercise that code both pre and post revert. However the tests don't
> detect an error either way.
The patch is unfortunately incorrect. Hardcoding 1 as the instance
can't work in general. I don't know what the correct fix is offhand.
I also don't see how it's a partial revert, as the patch looks nothing
like the code before the patch you say it reverts. If you could
explain how the call flow is different before and after the reverted
patch, that would be a more useful starting point.
More information about the wine-devel