mshtml/tests: Fix SysFreeString call with wrong variable.

Rico Schüller kgbricola at web.de
Sun Mar 1 07:39:24 CST 2009


Hi,

I'd like to have some feedback, before I send this to wine-patches.

This patch removes a regression in the mshtml test, where the wrong 
variable is called by SysFreeString, which leads sometimes to a crash ( 
http://test.winehq.org/data/0d7bec3578e02e1f551813e86100b59e36aec542/#group_Wine:mshtml:dom 
).

Is this fix correct?

A second problem is there a need to call SysFreeString() after each 
IHTMLStyle_get* when a variable isn't used any more because it does a 
Sys*AllocString* call (in get_nsstyle_attr)? Or is this call useless and 
automatically done when the app is terminated?

Cheers
Rico

---
  dlls/mshtml/tests/dom.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16b43164147c78b5b282260744e798944e742305.diff
Type: text/x-patch
Size: 568 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20090301/fcbf9237/attachment.bin 


More information about the wine-devel mailing list