Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

[Austin English]

On Sat, Mar 7, 2009 at 1:13 PM, Forest Hale <lordhavoc at ghdigital.com> wrote:
> I happen to agree with that sentiment, but Wine creates ~/.wine/drive_c and configures it as C:, for the sake of all common users this is correct.
>
> To force C: to be a fixed drive is not harmful in any case I can think of.
>
> It does not help if you set up wine with an installation in another drive letter, but that is a separate issue.
>
> Francois Gouget wrote:
>> On Fri, 6 Mar 2009, Forest Hale wrote:
>>
>>> Fixed GetDriveTypeW to always report C: as DRIVE_FIXED, preventing problems with the Steam installer if /home is a network share or other special mount.
>>>
>>> +    if (root && (root[0] == 'C' || root[0] == 'c')) return DRIVE_FIXED;
>>
>> I think you should not hardcode the c: drive here. Something based on
>> GetSystemDirectory(), GetWindowsDirectory() or one of their relatives
>> would be better (not sure exactly which should be used).

Please bottom post on Wine mailing lists.

Just because we currently make the system drive to be c by default
doesn't mean we can't support using D or some other letter does.
Making your code more portable now makes this easier to do in the
future.



-- 
-Austin