setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

James Hawkins truiken at gmail.com
Mon Mar 23 11:34:01 CDT 2009


On Sun, Mar 22, 2009 at 4:04 PM, Ricardo Filipe
<ricardojdfilipe at gmail.com> wrote:
> my next task was to fix this eheh.
> i think it would make more sense to just change
>
> if(!params->PathBuffer && !params->PathBufferSize)
>
> to
>
> if(!params->PathBuffer)
>

That's not what the patch does, but I did mistakenly leave an extra
copy of requiredSize > params->PathBufferSize in the top if statement.
 Feel free to send a correct patch.

-- 
James Hawkins



More information about the wine-devel mailing list