[1/3]msctf: ThreadMgr sink framework

Aric Stewart aric at codeweavers.com
Tue Mar 24 08:22:00 CDT 2009


Thanks, resent.

-aric

Alexandre Julliard wrote:
> Aric Stewart <aric at codeweavers.com> writes:
> 
>>  typedef struct tagACLMulti {
>>      const ITfThreadMgrVtbl *ThreadMgrVtbl;
>>      const ITfSourceVtbl *SourceVtbl;
>>      LONG refCount;
>>  
>>      ITfDocumentMgr *focus;
>> +
>> +    /* kept as separate lists to reduce unnecessary iterations */
>> +    struct list     pActiveLanguageProfileNotifySink;
>> +    struct list     pDisplayAttributeNotifySink;
>> +    struct list     pKeyTraceEventSink;
>> +    struct list     pPreservedKeyNotifySink;
>> +    struct list     pThreadFocusSink;
>> +    struct list     pThreadMgrEventSink;
> 
> Please pick better names for your variables. Hungarian notation is not a
> good idea in general, but incorrect Hungarian prefixes are even worse,
> these are not pointers.
> 



More information about the wine-devel mailing list