shell32: Implement IDD_MAKENEWFOLDER.

Juan Lang juan.lang at gmail.com
Thu Mar 26 18:56:09 CDT 2009


Hi John, a few problems with this one:

-{
+{
This whitespace-only change isn't needed for your patch, please omit it.

+        if (info->pidlRet == NULL)
+            return FALSE;
+        {
This is poor style, IMHO.  Surely an explicit else would be better
than the implicit else block here?

+				MessageBoxA( info->hwndTreeView,
+                   "You cannot create a new folder here. Choose a different
location.",
+                   "Invalid location", MB_OK );
The indentation is off, please match the surrounding code.  And, these
should be in resources, not in English in the source.

--Juan



More information about the wine-devel mailing list